Luxor/vested wg spending

[ignazio-bovo]

Addresses: #4948
based on top of #5062

Note: I have used the extrinsic vested_transfer inside the extrinsic spend_from_budget all extrinsic in substrate are now transactional by default, this means that if the vested_transfer fails then spend_from_budget is equivalent to a no-op.
Also I have created one internal account for each WG where tokens are minted before they are transferred with vesting.

[ignazio-bovo]

To be rebased onto #5062

[mnaamani]

I think there is a simpler way to do this, without needing to have an account on each working group.
Instead of pay_from_budget into the working group account then doing vesting::vested_transfer you should be able to pay from the budget directly into the target account, then do vesting::force_vested_transfer with source and target being the final destination. The balances::transfer inside force_vested_transfer will be a successful no-op, and then the vesting schedule will be applied.

[mnaamani]

Also I have created one internal account for each WG where tokens are minted before they are transferred with vesting.

#5072 (comment)

[mnaamani]

I think this now needs to be rebased on luxor since I merged the reduce council budget PR

[mnaamani]

some additional cleanup for build to works after refactor (removing the moduleId in working groups)

[mnaamani]

Benchmark is failing

Error: Input("Benchmark working_group::vested_spend_from_budget failed: AmountLow")
2024-03-29 22:54:25 Starting benchmark: working_group::vested_spend_from_budget    
There was a problem generating the weights for working_group, check the error above
Error: Process completed with exit code 1.

[mnaamani]

Benchmark is failing with error hereAmountLow because amount is less than vesting pallet configuration of <T as vesting::Config>::MinVestedTransfer::get()

[mnaamani]

So perhaps use that constant to make the amount_vesting at least that amount.

[mnaamani]

from earlier

[mnaamani]

So perhaps use that constant to make the amount_vesting at least that amount.

[mnaamani]

block_no is not used

[mnaamani]

strange that I'm seeing errors like ../../query-node/start.sh: line 11: docker-compose: command not found in CI workflow runs..
Has it been deprecated and we should replace all occurrences of that command with docker compose command?

I think you forgot to commit changes to: types/src/augment/augment-api-rpc.ts and types/src/augment/augment-types.ts

[mnaamani]

LGTM, next PR to luxor should commit changes to types/src/*.rs missed in this PR

Running integration tests locally on my machine works, we need to investigate why they are failing on github runners.