Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/not permitted unlink for 'pnpm clean' #650

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Aug 8, 2024

* Please fill in the required items.

Priority*

  • High: This PR needs to be merged first for other tasks.
  • Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Give users possibility to use pnpm clean script in 100% :)

Changes*

Add shut down turbo daemon before rimraf

How to check the feature

run pnpm clean

Reference

I was thinking also about total shut down of daemon, but i'm not sure, we're really need it.
@Jonghakseo If we don't need it, we can turn it off globally, but it isn't working properly for now.
I was sent question to turborepo community, let's wait for response :)
vercel/turborepo#8728 (comment)

@PatrykKuniczak PatrykKuniczak linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrykKuniczak PatrykKuniczak enabled auto-merge (squash) August 14, 2024 11:57
@PatrykKuniczak PatrykKuniczak merged commit cf89337 into main Aug 14, 2024
4 checks passed
@PatrykKuniczak PatrykKuniczak deleted the fix/clean-script-#648 branch August 14, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not permitted unlink for 'pnpm clean'
2 participants