Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition chunk metadata to ChunkEmbeddings output #14462

Open
wants to merge 2 commits into
base: release/552-release-candidate
Choose a base branch
from

Conversation

mehmetbutgul
Copy link
Contributor

Addition chunk metadata to ChunkEmbeddings output

Description

Previously, ChunkEmbeddings would lose the data in the chunk's original metadata in the output. This PR will continue to keep that metadata in the result.

Motivation and Context

When chunks are found by NERs, we get the entity information like {"entity": "NAME"}. Losing this information makes the result of ChunkEmbeddings unusable. I am thinking of writing a new annotator that takes the result of ChunkEmbeddings as input.

How Has This Been Tested?

I wrote a solid unit test and added a helper unit test class named AnnotationUtils.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant