Fixed LBDN and Pool Object for transform fields

[FIX] LBDN: auth_zone and pool field [FIX] POOL: servers and monitors field
JkhatriInfobox · Dec 7, 2023 · 5dcb52e · 5dcb52e
1 parent 5a7577b
commit 5dcb52e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/plugins/modules/nios_dtc_lbdn.py b/plugins/modules/nios_dtc_lbdn.py
@@ -178,7 +178,7 @@ def auth_zones_transform(module):
             for zone in module.params['auth_zones']:
                 zone_obj = wapi.get_object('zone_auth',
                                            {'fqdn': zone})
-                if zone_obj is not None:
+                if zone_obj:
                     zone_list.append(zone_obj[0]['_ref'])
                 else:
                     module.fail_json(
@@ -194,7 +194,7 @@ def pools_transform(module):
                                            {'name': pool['pool']})
                 if 'ratio' not in pool:
                     pool['ratio'] = 1
-                if pool_obj is not None:
+                if pool_obj:
                     pool_list.append({'pool': pool_obj[0]['_ref'],
                                       'ratio': pool['ratio']})
                 else:

diff --git a/plugins/modules/nios_dtc_pool.py b/plugins/modules/nios_dtc_pool.py
@@ -176,9 +176,11 @@ def servers_transform(module):
             for server in module.params['servers']:
                 server_obj = wapi.get_object('dtc:server',
                                              {'name': server['server']})
-                if server_obj is not None:
+                if server_obj:
                     server_list.append({'server': server_obj[0]['_ref'],
                                         'ratio': server['ratio']})
+                else:
+                    module.fail_json(msg='Server %s cannot be found.' % server)
         return server_list
 
     def monitors_transform(module):
@@ -187,8 +189,11 @@ def monitors_transform(module):
             for monitor in module.params['monitors']:
                 monitor_obj = wapi.get_object('dtc:monitor:' + monitor['type'],
                                               {'name': monitor['name']})
-                if monitor_obj is not None:
+                if monitor_obj:
                     monitor_list.append(monitor_obj[0]['_ref'])
+                else:
+                    module.fail_json(
+                        msg='monitor %s cannot be found.' % monitor)
         return monitor_list
 
     def topology_transform(module):