Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation and Subscription Message Display #313

Closed
wants to merge 1 commit into from

Conversation

Amruta7203
Copy link
Contributor

Title and Issue number

Title : Display subscription message below email input

Issue No. : 244

Close #244

Changes Made

The subscription message now displays directly below the email input and button, as intended.
The positions of the email input, subscribe button, and message are maintained without affecting the overall layout.

Screenshots (if applicable)

image
image
image

Checklist

  • [1] I have tested these changes locally.
  • [2] I have reviewed the code and ensured it follows the project's coding standards.
  • [3] I have updated the documentation (if necessary).
  • [4] I have read the contributing guidelines.

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shop-nex ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 3:14pm

@Amruta7203
Copy link
Contributor Author

@ivedmohan Raised the PR request for the issue. Had to perform email validation to display subscription message for correct email id's of authorized domains only.

@Vansh-Choudhary
Copy link
Collaborator

if i put a invalid text inside the email subscribe input field and press subscribe, the input box freezes and i'll have to reload the entire page in order to enter something else in the input field.
Fix this issue.

@Vansh-Choudhary Vansh-Choudhary added bug Something isn't working invalid This doesn't seem right and removed GSSOC level 1 bug Something isn't working labels May 18, 2024
@Amruta7203
Copy link
Contributor Author

@Vansh-Choudhary I have created a PR #331 which resolves the above query. The PR is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email validation and subscribe button not working
2 participants