AA: trie-based scope for library module #5451
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...inspired by google/ksp#2361 ^KT-71706 fixed
|
cc @ting-yuan |
|
Awesome, thanks a lot! |
|
|
||
| val root = TrieNode() | ||
|
|
||
| private val m = mutableMapOf<Pair<TrieNode, String>, TrieNode>().apply { |
There was a problem hiding this comment.
Why do we have a single, global map for the whole trie instead of modeling edges directly in TrieNode? To conserve memory (since we don't have to allocate a String -> TrieNode hash map per node)?
With the current solution, we allocate a new Pair for each access into the map in contains. Maybe that doesn't make a huge difference since we're also splitting the input path and allocating a lot that way, but still. contains should ideally avoid allocations since it can be frequently called.
There was a problem hiding this comment.
Do you have any benchmarks for this?
It's not going to block the merge, but I wonder how much time we now spend in contains splitting strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...inspired by google/ksp#2361
^KT-71706 fixed