-
Notifications
You must be signed in to change notification settings - Fork 4.1k
2.2.0 compatibility guide #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This update includes the first batch of language tickets to be included in the 2.2.0 compatibility guide
792f86c
to
0c102f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge effort @daniCsorbaJB ! Thanks for your hard work 🙏 Just a few things to check.
> | ||
> **Incompatible change type**: source | ||
> | ||
> **Short summary**: Constructor calls and inheritance using type aliases that expand to types that use variance modifiers such as `out` are no longer allowed in K2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> **Short summary**: Constructor calls and inheritance using type aliases that expand to types that use variance modifiers such as `out` are no longer allowed in K2. | |
> **Short summary**: Constructor calls and inheritance using type aliases that expand to types that use variance modifiers such as `out` are no longer supported by the K2 compiler. |
"In K2" seems vague so I tried to add additional explanation. It's OK to use in the header though.
> | ||
> **Deprecation cycle**: | ||
> | ||
> - 2.2.0: `-jvm-default` compiler option is set to `enable` by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the -Xjvm-default- option deprecated at the same time? And is the
-jvm-default` option documented in https://kotlinlang.org/docs/compiler-reference.html as part of another PR for Kotlin 2.2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's deprecated at the same time
hmm 🤔 - it was introduced to the Gradle compiler options doc and not to the generic compiler-reference. Should it also be included there? 🤔
> | ||
> **Incompatible change type**: source | ||
> | ||
> **Short summary**: `AbstractDoubleTimeSource` is deprecated; use `AbstractLongTimeSource` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a standard library API reference link for the preferred source? https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.time/-abstract-long-time-source/
> | ||
> **Incompatible change type**: source | ||
> | ||
> **Short summary**: `kotlin.native.Throws` is deprecated; use the common `kotlin.Throws` annotation instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a standard library API reference link for the preferred annoatation?
https://kotlinlang.org/api/core/kotlin-stdlib/kotlin/-throws/
Co-authored-by: Sarah Haggarty <[email protected]>
> | ||
> - 1.4.20: the plugin is deprecated | ||
> - 2.1.20: a configuration error is introduced, and no plugin code is executed | ||
> - 2.2.0: the plugin is removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> - 2.2.0: the plugin is removed | |
> - 2.2.0: the plugin code is removed |
This update is to create the 2.2.0 compatibility guide.
Related ticket is here: KT-77014 [Docs] 2.2.0 Compatibility Guide