Skip to content

Add enum class as valid K/JS exportable type #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented May 7, 2025

Better use the "Hide whitespaces" option to check the changes.

@lppedd lppedd requested a review from a team as a code owner May 7, 2025 10:34
@AlejandraPedroza AlejandraPedroza self-assigned this May 9, 2025
Copy link
Contributor

@AlejandraPedroza AlejandraPedroza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🚀

@lppedd
Copy link
Contributor Author

lppedd commented May 30, 2025

@AlejandraPedroza could you wait before merging? I need to clarify something with Artem and it makes sense to wait imo.

@JSMonk I've just realized that there is an issue in the types table: BooleanArray is mapped to Int8Array, but in practice it looks like it's compiled to a JS Array<Boolean>. Is this a docs issue, or is it some kind of missed optimization?

Edit: seems like Int8Array is in the docs since a long time but the compiler always emitted the boolean array (which also makes sense for interop).

@JSMonk
Copy link
Member

JSMonk commented Jun 1, 2025

@AlejandraPedroza could you wait before merging? I need to clarify something with Artem and it makes sense to wait imo.

@JSMonk I've just realized that there is an issue in the types table: BooleanArray is mapped to Int8Array, but in practice it looks like it's compiled to a JS Array<Boolean>. Is this a docs issue, or is it some kind of missed optimization?

Edit: seems like Int8Array is in the docs since a long time but the compiler always emitted the boolean array (which also makes sense for interop).

Oh, it's really a documentation issue. May I ask you to add the change regarding BooleanArray, too, but it should be a separate MR?
Thank you so much for noticing it 🙏

@lppedd
Copy link
Contributor Author

lppedd commented Jun 1, 2025

Sure, I'll open a new PR. Let's merge this one as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants