[change signature] support types defined in function signature #SCL-24118#717
Open
AdamJKing wants to merge 1 commit into
Open
[change signature] support types defined in function signature #SCL-24118#717AdamJKing wants to merge 1 commit into
AdamJKing wants to merge 1 commit into
Conversation
…4118 In the change signature dialog, update parameter / return-type fragments to use the target function as the fragment context instead of the parent class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #SCL-24118. This issue was happening for two reasons;
Any, and forgets the previous type.Using the function as the context instead and not setting a child (which isn't searched anyway) fixes the issue.