Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent size calculation in "vin indent object" extention #884

Merged
merged 1 commit into from
May 24, 2024

Conversation

Aisper
Copy link
Contributor

@Aisper Aisper commented May 15, 2024

Previously it ignored the first indent character, which caused errors with tabs. You wouldn't get any errors in behavior with spaces as you'd typically have 4 spaces at each indent level, so 1 in calculation doesn't make a difference.

Can be tested on following text. Easier with vii

first level selects all
{
	second level with tab. will still select all before fix
	{
		third level with tab. Will select also the second level before fix
	}
}

first level selects all
{
    second level with spaces. Will work before fix
    {
        third level with spaces. will only select that line
    }
}

@AlexPl292
Copy link
Member

Looks good to me, thank you!

@AlexPl292 AlexPl292 merged commit 746d483 into JetBrains:master May 24, 2024
1 check failed
AlexPl292 added a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants