fix: EXPOSED-236 Fix running tests with mysql8 #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
force-pushed
the
e5l/test-mysql-version
branch
from
e97f12b
to
c1da507
Compare
bog-walk
approved these changes
Jan 19, 2024
Comment on lines
58
to
65
| else -> | ||
| "jdbc:mysql://127.0.0.1:3002/" + | ||
| "testdb" + | ||
| "?useSSL=false" + | ||
| "&characterEncoding=UTF-8" + | ||
| "&zeroDateTimeBehavior=convertToNull" + | ||
| "&allowPublicKeyRetrieval=true" + | ||
| "&useSSL=false" | ||
| } |
There was a problem hiding this comment.
The useSSL=false property is set twice in this url.
Comment on lines
31
to
32
| Assume.assumeTrue(setOf(TestDB.MYSQL, TestDB.MARIADB, TestDB.POSTGRESQL, TestDB.SQLSERVER).containsAll(TestDB.enabledDialects())) | ||
| Assume.assumeFalse(System.getProperty("exposed.test.container") == "mysql8") |
There was a problem hiding this comment.
Rather than excluding mysql8 in both tests, I confirmed locally that both tests will pass if the system variable @@transaction_ISOLATION is used instead:
private fun Transaction.assertTransactionIsolationLevel(testDb: TestDB, expected: Int) {
// ...
TestDB.MYSQL, TestDB.MARIADB -> Triple("SELECT @@transaction_ISOLATION", "REPEATABLE-READ", "READ-COMMITTED")
}
|
@bog-walk, sorry for the long delay. It looks like we're out of memory because too many containers started. I don't want to have a failing build merged, so I will check what can be done. |
joc-a
force-pushed
the
e5l/test-mysql-version
branch
from
c5ad371
to
a28e614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EXPOSED-236 Gradle task testMysql8 runs tests on version 5.7.44