Remove ChannelId from YTS Videos #179
Conversation
There was a problem hiding this comment.
From what I remember seeing, only "Groups_InsertOrphanItems" has some exception handling, on the others the exceptions are sent to a higher level. Is this desirable? Is there any job that could continue even if an exception is raised? Or maybe could we insert some kind of retry in case of some exceptions?
| namespace DataLakeModels.Models.YouTube.Studio { | ||
|
|
||
| public class Group : IEquatable<Group> { | ||
| public Group() {} |
| public string ChannelId { get; set; } | ||
| public string Title { get; set; } | ||
| public DateTime RegistrationDate { get; set; } | ||
| public DateTime? UpdateDate { get; set; } |
There was a problem hiding this comment.
Does it make sense to have a null UpdateDate? Couldn't we just set to the RegistrationDate?
| public string Title { get; set; } | ||
| public DateTime RegistrationDate { get; set; } | ||
| public DateTime? UpdateDate { get; set; } | ||
| public List<Item> Items { get; set; } |
There was a problem hiding this comment.
Is this list accessible in the database? Is this created on the database?
| dirs.Add(path); | ||
| } | ||
| foreach (var dir in dirs) { | ||
| Console.WriteLine($"Now in {dir}"); |
There was a problem hiding this comment.
Do you think we need this every time we look for services?
|
|
||
| /* API METHODS */ | ||
|
|
||
| protected void ReportError(Errors e) { |
There was a problem hiding this comment.
Do we have a similar class on the other YouTube fetcher? If not, should we add it?
| RequestId = {e.RequestId} | ||
| "); | ||
| Logger.Error("For more information, see https://googleapis.dev/dotnet/Google.Apis.YouTubeAnalytics.v2/latest/api/Google.Apis.YouTubeAnalytics.v2.Data.Errors.html"); | ||
| throw new Exception("Response to API request contains an error. See message above."); |
There was a problem hiding this comment.
This exception is only caught outisde of this job, right? Is this desirable? Should there be error handling inside of the job before leaving it with an error?
moraesvic
force-pushed
the
hotfix/remove_channel_id_from_yts_videos
branch
from
1660ca5
to
4ac1cd4
Compare
Please consider PR #174 before assessing this
As we proceeded with the implementation of CSV Data Syncing on Year-Ap, it became clear that the column "ChannelId" was unnecessary (in fact detrimental) in this table