-
Notifications
You must be signed in to change notification settings - Fork 65
Moved the metadata into setup.cfg
#197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I've never used a Also, the CI checks did not pass. |
No strong benefits currently:
|
bfda66d
to
072445d
Compare
From some brief reading, it looks like |
8a82599
to
dac6f82
Compare
.github/workflows/python-package.yml
Outdated
@@ -41,3 +43,8 @@ jobs: | |||
run: | | |||
if python --version 2>&1 | grep -q "Python 2" || python --version 2>&1 | grep -q "Python 3.5" || python --version 2>&1 | grep -q "Python 3.6" ; then for synctest in $(cd tests && ls test*.py | grep -v async); do python -m unittest discover -s tests/ -t . -p "$synctest" || exit 1; done; fi | |||
if python --version 2>&1 | grep -q "Python 3.7" || python --version 2>&1 | grep -q "Python 3.8" || python --version 2>&1 | grep -q "Python 3.9" || python --version 2>&1 | grep -q "Python 3.10"; then coverage run --source adb_shell -m unittest discover -s tests/ -t . && coverage report -m && coveralls; fi | |||
- name: Upload wheel as a workflow artifact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used GitHub Actions to upload an artifact. What's the benefit of doing so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the benefit of doing so?
The ability to download created files (e.g. wheels) to use them somehow. For example, to get a proper wheel before making a release.
Not really a strong benefit, but sometimes allows you to get the artifact build on the CI. Can have various uses, from not-building the package as a part of other CI pipelines and using the wheel, to troubleshooting the issues on CI. |
c635a6e
to
06897c7
Compare
Added `pyproject.toml`. Version is now populated automatically from git tags using `setuptools_scm`. Deleted `bumpversion.sh`. Fixed some missing metadata fields. Fixed the scripts to work with `pyproject.toml` and cleaned them up.
Added
pyproject.toml
.Version is now populated automatically from git tags using
setuptools_scm
. Deletedbumpversion.sh
.Fixed some missing metadata fields.