Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow [$:] as prefix and plain ? for prepared statements #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow [$:] as prefix and plain ? for prepared statements #15

wants to merge 1 commit into from

Conversation

oger000
Copy link
Contributor

@oger000 oger000 commented Jul 26, 2018

This allows handling of the $-prefix (postgresql and sequelize bind), :-previx (PHP PDO and sequelize replace) and single ? (most DBS for prepared steatement.
But this PR allows this placeholder on more positions than the underlaying databases, so its for people who need preapared-statement support and know what they do. I am not shure if this should go into master. Anyway it works for me and is out for now.
By the way some trailing whitespace are stripped, so use git diff -w

@albin3 albin3 assigned albin3 and unassigned albin3 Jul 31, 2019
@albin3 albin3 added the discuss need to discuss label Jul 31, 2019
@albin3
Copy link
Member

albin3 commented Jul 31, 2019

hi @oger000 , thanks for the pr and sorry for the late reply.

There are two things need to be discussed:

@albin3 albin3 mentioned this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss need to discuss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants