Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH-1635 Revert most layer changes #70

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

sergehuber
Copy link
Member

JIRA

https://jira.jahia.org/browse/TECH-1635

Description

Go back to the old way and reestablish the original order.


#CI=true reduces the verbosity of the installation logs
RUN CI=true yarn set version ${YARN_VERSION} ; \
yarn install; \
/home/jahians/node_modules/.bin/cypress install
yarn install
Copy link
Member

@Fgerthoffert Fgerthoffert Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not keeping the --non-interactive ?

Previously:


CI=true yarn install --non-interactive

https://github.com/Jahia/jahia-cypress/blob/2755897be8f8a9aa5daf0230afbefe1fe0b356ca/env.Dockerfile#L18C5-L18C43

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's deprecated in Yarn v4

@Fgerthoffert Fgerthoffert self-requested a review March 18, 2024 16:04
@sergehuber sergehuber merged commit 74f7763 into main Mar 18, 2024
2 checks passed
@sergehuber sergehuber deleted the TECH-1635-revert-changes branch March 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants