Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stan dependencies to stack.yaml #3710 #3739

Merged
merged 5 commits into from
May 31, 2024
Merged

Added stan dependencies to stack.yaml #3710 #3739

merged 5 commits into from
May 31, 2024

Conversation

NoahCardoso
Copy link
Collaborator

Contributes to #3710. Added stan dependencies to stack.yaml. I was able to install stan and get it working on Drasil. Still need to address (or suppress) issues reported by stan as mentioned in #3710.

@balacij
Copy link
Collaborator

balacij commented May 16, 2024

Does this install stan as something we can run? I'm not quite sure how this works. Can you explain a bit more?

@NoahCardoso
Copy link
Collaborator Author

NoahCardoso commented May 16, 2024

  1. Install stan locally. Careful! stan must be compiled with the same GHC version we intend to use for compiling Drasil. As of Update stackage release: 20.20 (GHC 9.2.7) -> 20.26 (GHC 9.2.8) #3707, we're going to use GHC 9.2.8, but I could not get stan installed locally using GHC 9.2.X, so I had to update our project further to the GHC 9.4.X series by switching our targeted stack release to lts-21.25 (you can use the script found in Update stackage release: 20.20 (GHC 9.2.7) -> 20.26 (GHC 9.2.8) #3707 to quickly update this too). Afterwards, you will need to add some dependencies to our main stack.yaml file in the code folder and run stack install stan. That's what worked for me, but YMMV.

@balacij I completed this step. I added the dependencies and was able to run stan on the Drasil libraries. You still need to run stack install stan.

Copy link
Collaborator

@balacij balacij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! Ok, that makes more sense now, just two minor notes, but otherwise, this lets me install stan locally 🙂

@balacij
Copy link
Collaborator

balacij commented May 21, 2024

We force-pushed IRL to (1) rebase on master to avoid having the master commits shown in the PR [might be worth adding to the contributor's guide if it isn't already there], and (2) to remove accidentally committed .hie files. The third one was because we did the order in 2->1->2 and after the second one, the .hie files re-appeared, so we had to erase them again.

@balacij
Copy link
Collaborator

balacij commented May 28, 2024

@NoahCardoso Can you please move that last commit to a new branch+pr? Realistically, I know why foldl' is an improvement over foldl but it should be reflected in the PRs description, but it is good practice to keep our PRs separate.

@NoahCardoso
Copy link
Collaborator Author

I used a force push to undo my last commit

@samm82 samm82 mentioned this pull request May 29, 2024
@balacij
Copy link
Collaborator

balacij commented May 29, 2024

Thanks @NoahCardoso!

@JacquesCarette JacquesCarette merged commit b1f9d7b into master May 31, 2024
12 checks passed
@JacquesCarette JacquesCarette deleted the stan branch May 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants