Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed UncertainChunk to Uncertain #3726

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NoahCardoso
Copy link
Collaborator

I renamed the UncertainChunk datatype to just Uncertain as part of the renaming chunks named in the form "XChunk" as just "X".
Contributes to #3244

@samm82
Copy link
Collaborator

samm82 commented May 8, 2024

Based on @JacquesCarette's comment, since "Uncertain" is also an adjective, we may want to think of another name for these chunks as well. Perhaps investigating the difference between UncertainChunk and UncertQ would help shed some light on this!

@NoahCardoso
Copy link
Collaborator Author

NoahCardoso commented May 9, 2024

@samm82 would changing UncertainChunk to Uncertainty be better? Also do you want all of the Chunks to be nouns? I changed ParameterChunk to Param, UnitalChunk to Unital, UnitaryChunk to Unit, and CodeChunk to Code.

@JacquesCarette
Copy link
Owner

Now is our opportunity to think a bit deeper: UncertainChunk is the encoding of a ConstrainedChunk that adds an uncertainty field to it. It isn't "an uncertainty".

The problem with coming up with a good name for it is that it is likely to require coming up with a new better name for ConstrainedChunk first!

So there's a bigger issue (which you should probably get @samm82 and @balacij help you draft) about naming all things derived from Quantity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants