Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: PDE shape errors #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BugFix: PDE shape errors #38

wants to merge 1 commit into from

Conversation

yb6599
Copy link
Collaborator

@yb6599 yb6599 commented Oct 28, 2024

Hey @Jacob-Stevens-Haas, while running the PDE experiments, I got the error

ValueError: zero-size array to reduction operation maximum which has no identity

which suggests that the PDE array shapes are not conforming with the experiment setup. This PR changes the PDE data shapes, removes array lists since there's only one trajectory, and adds a signal parameter for noise_abs calculation, as x_test needs some reshaping to compute x_dot_test.

@Jacob-Stevens-Haas
Copy link
Owner

Jacob-Stevens-Haas commented Jan 25, 2025

I think we talked about this before your exam, but my understanding of this PR is that
(a) _gen_pde_data still needs to return a list of arrays for compatibility, even if its just attempting to create a single trajectory, and
(b) Using magic numbers for axes feels weird. It's hard to understand why these moveaxis commands are needed and if they're written correctly.
(c) creating a signal variable that stores the whole array in order to keep track of the axes seems excessive.

If you're still interested in doing this, can you explain what's wrong in more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants