Disable abs -> rel noise conversion #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change disambiguates the naming and values of axes between running the gridsearch, deciding which axes should be optimized vs scanned, and which should be recalculated in plotting. This is to allow better relative noise conversion, eventually: _PlotPrefs.rel_noise has been disallowed, as it does not behave correctly.
|
This branch should work to queue experiments; the only issues are with static typing and python 3.10 |
Is this supposed to be added in config? LGTM. |
Yeah, you'll have to add it to an |
Python 3.10 does not allow generic TypedDicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change clarifies the transition of grid params (every parameter used in all series that varies in the gridsearch) to scan params (only those that remain after argmax/argmin) to finally, plot params (those that go into final plots). Given the removal of the ability to convert parameters after experiments, plot params are the same as scan params until that feature is re-enabled.
This also fixes the issue with different gridpoints using different simulations; thanks @yb6599 for spotting this.
To use the new branch, change the
grid_valsandgrid_paramsto use"sim_params.rel_noise"instead of absolute noise.ALSO - unrelated, but can you add
unbias=Truein the MIOSR optimizer used?