Skip to content

74-sort-card #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2025
Merged

74-sort-card #87

merged 6 commits into from
Apr 23, 2025

Conversation

cercil0605
Copy link
Member

@cercil0605 cercil0605 commented Apr 16, 2025 •
edited by kimurash
Loading

Issue

概要

公開・非公開で切り替えた時意味不明な並べ替えを実行する

やったこと

  • そもそもログの表示をdevとproductionでうまく切り替えれてなかったので改善
  • supabaseのSQLにて，update_atを自動更新するようにトリガ，関数設定
  • それを検証するテストを作成，pytestまたはそれに対応するフォルダの用意

動作確認方法

以下コマンドを実行すること

PYTHONPATH=. pytest -s

@cercil0605 cercil0605 requested a review from kimurash April 16, 2025 13:25
@cercil0605 cercil0605 added the bug Something isn't working label Apr 16, 2025
@cercil0605 cercil0605 self-assigned this Apr 16, 2025
kimurash
kimurash reviewed Apr 17, 2025
View reviewed changes
@cercil0605
Copy link
Member Author

コメント返した．明日対処する．

@cercil0605 cercil0605 requested a review from kimurash April 21, 2025 08:32
@cercil0605 cercil0605 requested a review from kimurash April 22, 2025 04:55
kimurash
kimurash approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@kimurash kimurash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cercil0605 cercil0605 merged commit f04962a into main Apr 23, 2025
@cercil0605 cercil0605 deleted the 74-sort-card branch April 23, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimurash kimurash kimurash approved these changes

Assignees

@cercil0605 cercil0605

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

公開・非公開ボタンを押したときにカードが並び変わらないようにする
2 participants
@cercil0605 @kimurash