-
Notifications
You must be signed in to change notification settings - Fork 0
面接の情報を保存するDBをFirestoreに変更した #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR switches the interview data storage from the previous backend to Firestore, updating the dependencies, Docker configuration, and repository implementation.
- Added the Google Cloud Firestore dependency.
- Included a Firestore emulator service in Docker Compose.
- Implemented a Firestore interview repository and updated API dependencies.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
backend/pyproject.toml | Added the "google-cloud-firestore" dependency. |
backend/docker-compose.yml | Added a Firestore emulator service to support local development. |
backend/app/infrastructure/repositories/firestore/interview_repository.py | New repository implementation for Firestore using batch writes. |
backend/app/api/dependencies.py | Updated dependency injection to use FirestoreInterviewRepository. |
backend/README.md | Updated instructions to start the Firestore emulator along with Redis. |
backend/.env.sample | Added environment variables required for Firestore configuration. |
backend/app/infrastructure/repositories/firestore/interview_repository.py
Show resolved
Hide resolved
backend/app/infrastructure/repositories/firestore/interview_repository.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue
目的
データベースにかかる料金を抑えるため
やったこと
google-cloud-firestore
をインストールしたdocker-compose.yml
に追加した.env
に追加した動作確認
テスト結果
面接の一連の流れ