Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSM #21966 - Allow cardinal directions as roles in road routes. #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZLima12
Copy link

@ZLima12 ZLima12 commented Mar 24, 2022

The wiki page for route relations states:

In Canada, New Zealand, and the United States, the a role set to a cardinal direction indicates which of the route's official route directions the way carries when the route is mapped as a single bidirectional relation.

This fixes the erroneous warnings that are issued when modifying road relations mapped in this style.

The wiki page for route relations states:
In Canada, New Zealand, and the United States, the a role set to a
cardinal direction indicates which of the route's official route
directions the way carries when the route is mapped as a single
bidirectional relation.
@1ec5
Copy link

1ec5 commented Mar 24, 2022

Here’s more detail about the mapping style that this PR would accommodate. It’s one of two styles in wide use, though the PTv2-style directional subrelations are more rigorous and already supported by JOSM. A similar change was previously discussed on the josm-dev mailing list back in 2013.

@ZLima12
Copy link
Author

ZLima12 commented Mar 24, 2022

I do recognize the superiorities of using one relation for each direction, but with the prevalence of this mapping style, I feel that JOSM should at least recognize it as valid. Having warnings that are "safe to dismiss" like this desensitizes mappers to legitimate warnings.

@ZLima12
Copy link
Author

ZLima12 commented Mar 24, 2022

If we want to formally deprecate this style, then I think JOSM should give warnings about it. But until then I think it should allow it.

@1ec5
Copy link

1ec5 commented Mar 24, 2022

No argument there, just trying to give context about why perhaps there hadn’t been motion on this change since it was first discussed back in 2013.

@ZLima12
Copy link
Author

ZLima12 commented Mar 25, 2022

@stoecker stoecker changed the title Allow cardinal directions as roles in road routes. JOSM #21966 - Allow cardinal directions as roles in road routes. May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants