Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See #23555: Explicitely keep tags from both objects when conflating #19

Closed
wants to merge 3 commits into from

Conversation

tsmock
Copy link

@tsmock tsmock commented Mar 21, 2024

No description provided.

Measurements pre-patch:
* CPU Time: 3272770 ms
* Memory: 1.78 TB
* Total time: 54:55

Measurements post-patch:
* CPU Time: 1600090 ms (-51.1%)
* Memory: 117.41 GB (-93.4%)
* Total time: 26:45 (-53.5%)

An additional note is that time spent in GC was reduced by ~51% as well.

Signed-off-by: Taylor Smock <[email protected]>
@tsmock tsmock changed the title See #23555: Explicitely keep tags from both objects when conflating #14 See #23555: Explicitely keep tags from both objects when conflating Mar 21, 2024
Measurements pre-patch:
* CPU Time: 1600090 ms
* Memory: 117.41 GB
* Total time: 26:45

Measurements post-patch:
* CPU Time: 827613 ms (-48.3%)
* Memory: 166.57 GB (+41.9%)
* Total time: 13:50 (-51%)

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Copy link
Author

tsmock commented Apr 1, 2024

JOSM core reverted the changes.

@tsmock tsmock deleted the fixup-23555 branch April 1, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant