Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions deprecations and warnings #154

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Fix GitHub Actions deprecations and warnings #154

merged 3 commits into from
Sep 10, 2024

Conversation

JOJ0
Copy link
Owner

@JOJ0 JOJ0 commented Sep 10, 2024

Fixes #133

by upgrading them to current versions.
@JOJ0 JOJ0 marked this pull request as ready for review September 10, 2024 06:21
@JOJ0
Copy link
Owner Author

JOJ0 commented Sep 10, 2024

Sorry @JacksonChen666, not really ready for review. Just desperately trying to trigger the release workflow. As I understood it, it should be sufficient to push a tag named v* to trigger it. But it doesn't seem to work...Hmm 🤔

@JOJ0
Copy link
Owner Author

JOJ0 commented Sep 10, 2024

Ok got it, retag.sh helped to remind me on how to trigger/test all this.

Now it's ready to review. Note that in this case the failed release workflow is a good thing. It tells us that the workflow is running as planned triggered via my test-tag-push (v0.46.2) and at least this "early exit" on version mismatch is doing its job correctly:

Screenshot 2024-09-10 at 09 31 15

(Now deleted test tag v0.46.2 again)

As far as I can see all the deprecations as documented in the screenshot in #133 (headline "Annotations") are gone, but please double check!

Copy link
Collaborator

@JacksonChen666 JacksonChen666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part, seems fine.

I tried testing changes in my own repo (can't be a fork because... reasons1). It didn't work and spit the error Resource not accessible by integration, implying that permissions are needed, but since releases worked on JOJ0/synadm already (for whatever reason), I'm just gonna assume it's gonna work as well.

Footnotes

  1. See error on https://github.com/JacksonChen666/synadm/actions/runs/10788162806

@JOJ0 JOJ0 merged commit 0cd2d30 into master Sep 10, 2024
4 of 6 checks passed
@JOJ0
Copy link
Owner Author

JOJ0 commented Sep 10, 2024

Thanks for testing! Seems fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions pipeline "release" throwing deprecations/warnings
2 participants