-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub Actions deprecations and warnings #154
Conversation
by upgrading them to current versions.
4e4208d
to
817ca13
Compare
Sorry @JacksonChen666, not really ready for review. Just desperately trying to trigger the |
Ok got it, Now it's ready to review. Note that in this case the failed release workflow is a good thing. It tells us that the workflow is running as planned triggered via my test-tag-push (v0.46.2) and at least this "early exit" on version mismatch is doing its job correctly: (Now deleted test tag v0.46.2 again) As far as I can see all the deprecations as documented in the screenshot in #133 (headline "Annotations") are gone, but please double check! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part, seems fine.
I tried testing changes in my own repo (can't be a fork because... reasons1). It didn't work and spit the error Resource not accessible by integration
, implying that permissions are needed, but since releases worked on JOJ0/synadm already (for whatever reason), I'm just gonna assume it's gonna work as well.
Footnotes
Thanks for testing! Seems fine! |
Fixes #133