Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix existing calls to user_list API breaking #128

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix existing calls to user_list API breaking #128

merged 3 commits into from
Sep 14, 2023

Conversation

JacksonChen666
Copy link
Collaborator

@JacksonChen666 JacksonChen666 commented Sep 14, 2023 •
edited
Loading

fixes #127

JOJ0
JOJ0 requested changes Sep 14, 2023
View reviewed changes
synadm/cli/notice.py Show resolved Hide resolved
@JacksonChen666 JacksonChen666 changed the title fix the rest of user_list missing admin arg Fix existing calls to user_list API breaking Sep 14, 2023
JOJ0
JOJ0 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Owner

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@JacksonChen666 JacksonChen666 merged commit 1e10ab8 into master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JOJ0 JOJ0 JOJ0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User list function breaking change
2 participants
@JacksonChen666 @JOJ0