Use requests.request instead of getting attrs to make requests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting attributes is kind of hacky and not really that readable (or easily understood), so requests.request was used because it accepts http methods
JacksonChen666
force-pushed
the
less-hacky-request-method
branch
from
47203b0
to
1c2c50d
Compare
|
I do not understand why flake8 is failing. It's not on my side. |
|
@JacksonChen666 please pull --rebase from master, it will fix your flake8 issue. 👍 |
|
already rebased |
|
I triggered a rerun with debug loggin enabled of the linter gh-actions thing. let's see... |
|
Still same error. It's odd since it points to exactly those lines I fixed recently. My suggestion would be: Go ahead and merge it. I loosely assume this is some caching issue w gh-actions or the like. If it happens in master again I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting attributes is kind of hacky and not really that readable (or easily understood), so requests.request was used because it accepts HTTP methods.
(yeah I left the commit hanging around for a good few days)