Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement room delete v2 API #113

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Implement room delete v2 API #113

merged 4 commits into from
Jul 27, 2023

Conversation

JacksonChen666
Copy link
Collaborator

@JacksonChen666 JacksonChen666 commented Jul 26, 2023 •
edited
Loading

fixes #49
fixes #50

@JacksonChen666 JacksonChen666 requested a review from JOJ0 July 26, 2023 21:45
@JacksonChen666 JacksonChen666 marked this pull request as draft July 26, 2023 21:48
@JacksonChen666 JacksonChen666 marked this pull request as ready for review July 26, 2023 21:53
@JacksonChen666 JacksonChen666 linked an issue Jul 26, 2023 that may be closed by this pull request
Support v2 of the room delete API #49
Closed
@JacksonChen666
implement room delete v2 status in CLI
d0785a0 
doesn't check whether both is used but that should be handled by the
mutually exclusive thing
@JacksonChen666
Copy link
Collaborator Author

Note: merges into the dev branch. If that's not desired, "edit" the PR title and change the base option to something else (and keep the PR title the same unless you want to change it).

@JacksonChen666 JacksonChen666 linked an issue Jul 27, 2023 that may be closed by this pull request
Support new API's to query room delete status #50
Closed
@JOJ0
Copy link
Owner

JOJ0 commented Jul 27, 2023

merge to master plz. I'm afk and cant find the option to cgange on mobile.

@JacksonChen666 JacksonChen666 changed the base branch from dev to master July 27, 2023 14:17
@JacksonChen666
Copy link
Collaborator Author

JacksonChen666 commented Jul 27, 2023 •
edited
Loading

merge to master plz. I'm afk and cant find the option to cgange on mobile.

done

JOJ0
JOJ0 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Owner

@JOJ0 JOJ0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please merge and release whenever you find the time for it.

synadm/cli/room.py Show resolved Hide resolved
synadm/cli/room.py Show resolved Hide resolved
@JacksonChen666 JacksonChen666 merged commit 4bdcdf7 into JOJ0:master Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JOJ0 JOJ0 JOJ0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new API's to query room delete status Support v2 of the room delete API
2 participants
@JacksonChen666 @JOJ0