Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set report title in cmd mode #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbanck
Copy link

@mbanck mbanck commented Mar 26, 2020

This adds an additional command-line option -cmd-title which allows to
overwrite the default title (i.e. dashboard name). Depending on the dashboard
naming scheme, or the particular time-range of the report, the user might want
to set a custom title (like `Daily report for...') without having to use custom
templates.

This adds an additional command-line option -cmd-title which allows to
overwrite the default title (i.e. dashboard name). Depending on the dashboard
naming scheme, or the particular time-range of the report, the user might want
to set a custom title (like `Daily report for...') without having to use custom
templates.
@IzakMarais
Copy link
Owner

Thanks for this. It looks like it is also available as a query parameter? I would not like an option to be only accessible from the cmd line.

If it is could you did not add it to the query parameters section of the readme?
Also is there any automated test that one might think of for this? E.g. here to test the url parsing and here to verify that the custom title is correctly passed through to the generated report?

If you add these I would gladly accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants