Add PlutusTx.Data.List.destructList #6945
Conversation
zliu41
changed the title
| ((\tail -> tail (tail (force tailList nt))) | ||
| (\eta -> force tailList eta))) | ||
| (unIData (force headList nt))) | ||
| (force tailList (unListData d)))) |
There was a problem hiding this comment.
That's a lot of forcing, why not bind force tailList and force headList to a variable? Or do you expect CSE to clean it up? Particularly when you already seem to do that in (\eta -> force tailList eta). Why the eta-expansion btw?
There was a problem hiding this comment.
We don't CSE work-free terms such as force tailList. As mentioned in the CSE Note, doing so may reduce size but always increases cost, and CSE currently favors smaller cost. I don't think there is a way to manually bind force tailList to a variable, is there?
There was a problem hiding this comment.
It's not really work-free, since both Force and Builtin have a cost. Var has a cost too, but it's 1 against 2, so binding it to a variable should be an overall cost reduction.
I don't think there is a way to manually bind force tailList to a variable, is there?
I don't know.
There was a problem hiding this comment.
There's also LamAbs and App, though perhaps if a builtin is forced many times, it may be worth hoisting it.
There was a problem hiding this comment.
The file is named ...unsafeFixIO_th_utils... for a reason that I don't understand, but that doesn't matter much, I guess.
There was a problem hiding this comment.
I think it's because my git email is unsafeFixIO@gmail.com.
| -- | Prints uniques. This should be used sparingly: a simple change to a script or a | ||
| -- compiler pass may change all uniques, making it difficult to see the actual | ||
| -- change if all uniques are printed. It is nonetheless useful sometimes. | ||
| goldenPirReadableU :: | ||
| (PrettyUni uni, Pretty fun, uni `PLC.Everywhere` Flat, Flat fun) => | ||
| String -> | ||
| CompiledCodeIn uni fun a -> | ||
| TestNested | ||
| goldenPirReadableU name value = | ||
| nestedGoldenVsDoc name ".pir" | ||
| . maybe "PIR not found in CompiledCode" (prettyReadable . view progTerm) | ||
| $ getPirNoAnn value | ||
|
|
There was a problem hiding this comment.
Please apply fourmolu to this new code (and other new code too) if you haven't done it yet.
There was a problem hiding this comment.
There's no way to only fourmolu a single function, is it? I don't want to fourmolu the whole module, since I only added this one function. We can format it in a separate PR.
This seems not only useful for @adamsmo's scripts, but also useful in general. See Haddock for more details.
Closes #6936