Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span-calculation: comment 85% CPU span calculation #5948

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NadiaYvette
Copy link
Contributor

@NadiaYvette NadiaYvette commented Aug 12, 2024

Description

Anomalies were seen with 85% CPU span calculations. This is at least trying to figure out what's going on and explain it to everyone else. That said, it appears the trouble is most likely in emitting the traces, given what Micha just spotted instantly upon looking at it today. At the very least, the audit of the reporting calculations produced some comments even if it didn't find the bug.

This consists exclusively of adding comments to the code. There should be no runtime effects. At most I might have to fix up some new haddock warnings.

This was documentation as a by-product of an auditing/debugging effort.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

This consists exclusively of adding comments, so it might at worst trigger some new haddock warnings. I'll fix whatever of those crops up, too, of course.

@NadiaYvette NadiaYvette self-assigned this Aug 12, 2024
@NadiaYvette NadiaYvette requested a review from a team as a code owner August 12, 2024 16:27
@NadiaYvette NadiaYvette force-pushed the nadia.chambers/span-calculation-001 branch from 5dcf84a to 55f7817 Compare August 13, 2024 13:19
@NadiaYvette NadiaYvette reopened this Aug 13, 2024
@NadiaYvette
Copy link
Contributor Author

Sorry about the noise with the accidental closing & re-opening. I fat fingered a push & ended up pushing a tree identical to master over it.

Anomalies were seen with 85% CPU span calculations. This is at least
trying to figure out what's going on and explain it to everyone else.
@NadiaYvette NadiaYvette force-pushed the nadia.chambers/span-calculation-001 branch from b2c13e7 to 7be8bc1 Compare August 26, 2024 14:41
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant