span-calculation: comment 85% CPU span calculation #5948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Anomalies were seen with 85% CPU span calculations. This is at least trying to figure out what's going on and explain it to everyone else. That said, it appears the trouble is most likely in emitting the traces, given what Micha just spotted instantly upon looking at it today. At the very least, the audit of the reporting calculations produced some comments even if it didn't find the bug.
This consists exclusively of adding comments to the code. There should be no runtime effects. At most I might have to fix up some new haddock warnings.
This was documentation as a by-product of an auditing/debugging effort.
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
This consists exclusively of adding comments, so it might at worst trigger some new haddock warnings. I'll fix whatever of those crops up, too, of course.