Protocol parameter update with guard rail script #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/protocol-param-update-with-guardrail
branch
5 times, most recently
from
d1fdfc3
to
efe6f73
Compare
carbolymer
approved these changes
May 16, 2024
Comment on lines
+34
to
+35
| -- program-options | ||
| -- ghc-options: -Werror |
There was a problem hiding this comment.
Suggested change
| -- program-options | |
| -- ghc-options: -Werror | |
| program-options | |
| ghc-options: -Werror |
Comment on lines
+81
to
+90
| H.writeFile proposalAnchorFile "dummy anchor data" | ||
| proposalAnchorDataBS <- evalIO $ BS.readFile proposalAnchorFile |
| , Map.singleton pv2 defaultV2CostModel | ||
| , Map.singleton pv3 defaultV3CostModel | ||
| ] | ||
| defaultV1CostModel = Api.CostModel |
There was a problem hiding this comment.
are those V1 and V2 values the same as in default genesis in cardano-api? Maybe it would be better to reference values from the default genesis there instead of redefining them here?
Same with V3 - maybe it would be better to just update single elements in the list instead?
carbolymer
reviewed
May 16, 2024
| numVotes = length allVotes | ||
| annotateShow numVotes | ||
|
|
||
| guardRailScript <- H.note $ work </> "guard-rail-script.plutusV3" |
There was a problem hiding this comment.
Just out of curiosity, what does this script do?
There was a problem hiding this comment.
Nothing it defaults to True. I want to bring plutus-example into cardano-node so we can see the script in in Haskell.
Jimbo4350
force-pushed
the
jordan/protocol-param-update-with-guardrail
branch
from
efe6f73
to
0586d27
Compare
9 tasks
Jimbo4350
force-pushed
the
jordan/protocol-param-update-with-guardrail
branch
2 times, most recently
from
cefd5a6
to
cc79ef6
Compare
keys and the dreps
Jimbo4350
force-pushed
the
jordan/protocol-param-update-with-guardrail
branch
from
cc79ef6
to
4655aa1
Compare
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.