Fix Issue#2151 MEDLEY-INIT-VARS now resets the LI pseudohost whenever it resets the value of LOGINHOST/DIR #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is resets the value of LOGINHOST/DIR - providing PSEUDOHOSTS is load and LI pseudohost already exists.
MattHeffron
reviewed
May 16, 2025
| @@ -193,8 +190,12 @@ | |||
| (IRM.HOST&DIR (MEDLEYDIR '"docs/dinfo")) | |||
| (IRM.DINFOGRAPH) | |||
| (DIRECTORIES (APPEND LISPUSERSDIRECTORIES LISPSOURCEDIRECTORIES)) | |||
| [LOGINHOST/DIR (DIRECTORYNAME (OR (UNIX-GETENV "LOGINDIR") | |||
| (UNIX-GETENV "HOME"] | |||
| (LOGINHOST/DIR (LET [(LHD (DIRECTORYNAME (OR (UNIX-GETENV "LOGINDIR") | |||
There was a problem hiding this comment.
This doesn't appear to match what the PR description states. The LI pseudohost looks like it is reset anytime LOGINHOST/DIR is set. I.e., it isn't only when changed.
Does it matter?
There was a problem hiding this comment.
Technically ypu are correct, should be set/reset. But practically, whenever MEDLEY-INIT-VARS is executed (after sysout, after makesys, during greet, etc) LOGINHOST/DIR has already been set and it is be reset. Only exception is somewhere in the loadup process where LOGINHOST/DIR is first set - but I am not sure whether by MEDLEY-INIT-VARS or otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MEDLEY-INIT-VARS now resets the LI pseudohost whenever it resets the value of LOGINHOST/DIR - providing PSEUDOHOSTS is loaded and LI pseudohost already exists. See Issue 2151 for more information.