Fix for possible zombie items from MakePermanent action #2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwelveEyes
force-pushed
the
fix-make-permanent-desync
branch
from
5083d3e to
942f2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was somewhat addressed in the past, but it only resyncs permanency between the virtual quest item and the inventory item with item transfer (e.g. foe has quest items; those quest items are made permanent; foe is killed and player loots those quest items). It doesn't cover items already in the player inventory when a
MakePermanentaction happens, potentially leading to a desynced state — the dreaded "zombie" item.This workaround should fix the issue in a low impact way by resyncing permanency when the inventory window is setup and when it refreshes.Changed to be much cleaner, though it won't fix bugged items already made permanent in saves retroactively.
Fixes #2720