Refactor FormulaHelper to read racial resistances #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FormulaHelper previously applied racial resistances by reading the player's race directly. With this change, the saving throw calculation will be modified by the contents of the player's RaceTemplate. Addresses the following issue: Interkarma#2660
| else if (elementType == DFCareer.Elements.Magic && target == playerEntity && playerEntity.Race == Races.Breton) | ||
|
|
||
| // Apply racial resistances | ||
| var raceTemplate = playerEntity.GetLiveRaceTemplate(); |
There was a problem hiding this comment.
Seems like the check for whether the target is the player entity is missing.
There was a problem hiding this comment.
Yep, fixed that now.
petchema
previously approved these changes
Jul 7, 2024
ajrb
previously approved these changes
Jul 17, 2024
|
I'm not convinced with the changes in this PR. It feels incomplete.
I guess the main point is really missing Breton flag for Resistance, so maybe I should let this PR pass. It just feels like a wasted opportunity if we just do the data-driven formula halfway |
KABoissonneault
requested changes
Aug 13, 2024
Removes hardcoded high elf immunity from FormulaHelper and uses flags set by RaceTemplate instead. Moves application of player racial flags up in the file so that the saving throw can be assigned to 100 before modification.
|
Added a new commit that uses RaceTemplate for all saving throw-related flags. See commit description for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormulaHelper previously applied racial resistances by reading the player's race directly. With this change, the saving throw calculation will be modified by the contents of the player's RaceTemplate.
Addresses the following issue:
#2660