Skip to content

Add quantiles to request metrics, correct metric postfix #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ozeidan
Copy link

@ozeidan ozeidan commented Mar 27, 2025

...the new summary collector will expose the metrics with three names: http_server_requests_seconds(_sum|_count)? and quantile labels, making the former counter metric redundant and making the metric names more consistent with conventions. Leaving in a "legacy" metric collector to avoid breaking existing monitoring and alerting setups that depend on the metric with postfix "_sum_sum".

@ozeidan ozeidan force-pushed the feature/request-metrics branch 4 times, most recently from 437004d to 759bf8e Compare March 27, 2025 15:40
Ing0R
Ing0R previously approved these changes Mar 27, 2025
@ozeidan ozeidan force-pushed the feature/request-metrics branch 4 times, most recently from b5a0646 to 8d90cbc Compare March 27, 2025 15:45
...the new summary collector will expose the metrics with three names:
http_server_requests_seconds(_sum|_count)?, making the former counter
metric redundant and making the metric names more consistent with
conventions. Leaving in a "legacy" metric collector to avoid breaking existing monitoring
and alerting setups that depend on the metric with postfix "_sum_sum".
@ozeidan ozeidan force-pushed the feature/request-metrics branch from 8d90cbc to 0844061 Compare March 27, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants