Add quantiles to request metrics, correct metric postfix #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozeidan
force-pushed
the
feature/request-metrics
branch
4 times, most recently
from
437004d to
759bf8e
Compare
Ing0R
previously approved these changes
Mar 27, 2025
ozeidan
force-pushed
the
feature/request-metrics
branch
4 times, most recently
from
b5a0646 to
8d90cbc
Compare
...the new summary collector will expose the metrics with three names: http_server_requests_seconds(_sum|_count)?, making the former counter metric redundant and making the metric names more consistent with conventions. Leaving in a "legacy" metric collector to avoid breaking existing monitoring and alerting setups that depend on the metric with postfix "_sum_sum".
ozeidan
force-pushed
the
feature/request-metrics
branch
from
8d90cbc to
0844061
Compare
Ing0R
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...the new summary collector will expose the metrics with three names: http_server_requests_seconds(_sum|_count)? and quantile labels, making the former counter metric redundant and making the metric names more consistent with conventions. Leaving in a "legacy" metric collector to avoid breaking existing monitoring and alerting setups that depend on the metric with postfix "_sum_sum".