Add lin-bus dependency #2004
Closed
Add lin-bus dependency #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
reviewed
Nov 5, 2022
| implementation(libs.jchronic) { | ||
| exclude(group = "junit", module = "junit") | ||
| } | ||
| implementation("com.thoughtworks.paranamer:paranamer:2.6") |
There was a problem hiding this comment.
Paranamer is built in to Java 8 onwards, we don't need to add it, hence we removed it years ago.
There was a problem hiding this comment.
This will be fixed in the next commit.
BlockyTheDev
suggested changes
Nov 5, 2022
| maven { | ||
| name = "PaperMC" | ||
| url = uri("https://repo.papermc.io/repository/maven-public/") | ||
| url = uri("https://papermc.io/repo/repository/maven-public/") |
There was a problem hiding this comment.
Why was this changed back? On 20.05.2022 PaperMC announced the change to the new URLs. After the announcement, the URL got changed here by a pull request coming from me (#1756)
There was a problem hiding this comment.
Thanks for that info. I wasn't aware. Those changes came from upstream. I'll revert them.
| @@ -14,7 +14,7 @@ applyShadowConfiguration() | |||
| repositories { | |||
| maven { | |||
| name = "PaperMC" | |||
| url = uri("https://repo.papermc.io/repository/maven-public/") | |||
| url = uri("https://papermc.io/repo/repository/maven-public/") | |||
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a dependency on EngineHub/lin-bus.
Description
Adds a dependency on EngineHub/lin-bus which has been used by upstream since July. It updates the ccom.sk89q.jnbt package with the upstream changes required for this change. This change brings us closer to being compatible with the WorldEdit API again.
Submitter Checklist
@since TODO.