Skip to content

reverse the order of individual FFTs in rfftn #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 10, 2025

For numpy.fft.fftn and numpy.fft.ifftn, individual FFTs over axes are performed in reverse order.

Similarly, for numpy.fft.rfftn, individual FFTs are performed in reverse order.

However, for numpy.fft.irfftn individual FFTs are performed in forward order.

dpnp.fft.irfftn is updated to behave similar to numpy.fft.irfftn.
Note that the order is only important when there is repeated indices in axes and s is not None.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Jul 10, 2025
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2524/index.html

Copy link
Contributor

github-actions bot commented Jul 10, 2025

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_8 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2025

Coverage Status

coverage: 72.098% (+0.01%) from 72.088%
when pulling 7c9b885 on fix-irfftn
into 425ec0c on master.

@vtavana vtavana marked this pull request as ready for review July 10, 2025 20:44
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 11, 2025
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants