Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect results from cumulative_sum and cumulative_prod with dtype=bool #2018

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

ndgrigorian
Copy link
Collaborator

This PR resolves gh-2017 by introducing missing dedicated kernels for bool->bool in the type matrix of cumulative_sum and cumulative_prod.

Also slips in the addition of int8->int8

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

bool->bool and int8->int8 overloads were missing in cumulative_sum and cumulative_prod
Copy link

github-actions bot commented Feb 25, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_550 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 25, 2025

Coverage Status

coverage: 88.138% (-0.1%) from 88.233%
when pulling fa525a7 on resolve-gh-2017
into 5e1c87d on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review February 25, 2025 22:23
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_4 ran successfully.
Passed: 892
Failed: 4
Skipped: 118

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_9 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

antonwolfy
antonwolfy previously approved these changes Feb 27, 2025
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, thank you @ndgrigorian

Documents the ticket reported for the JIT failure on CPU
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_10 ran successfully.
Passed: 895
Failed: 2
Skipped: 125

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 0d0ff97 into master Feb 28, 2025
72 of 73 checks passed
@ndgrigorian ndgrigorian deleted the resolve-gh-2017 branch February 28, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpt.cumulative_sum returns incorrect result for dtype=dpt.bool
3 participants