Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical debt clean-up in _accumulation.py #2011

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Technical debt clean-up in _accumulation.py #2011

merged 2 commits into from
Feb 26, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 21, 2025 •
edited
Loading

This PR cleans up _accumulate_common function which is used internally by accumulators

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Clean up code in _accumulation.py
67fbdc3 
Renamed events
Remove unnecessary instantiation of a SyclEvent
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_536 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2025 •
edited
Loading

Coverage Status

coverage: 88.232% (-0.001%) from 88.233%
when pulling cd2bd1a on clean-up-accumulator-common-code
into 7e2b69e on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review February 24, 2025 17:24
vtavana
vtavana previously approved these changes Feb 24, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_3 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@ndgrigorian ndgrigorian requested a review from vtavana February 26, 2025 06:55
@ndgrigorian ndgrigorian merged commit c6b00c7 into master Feb 26, 2025
70 of 72 checks passed
@ndgrigorian ndgrigorian deleted the clean-up-accumulator-common-code branch February 26, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @vtavana