Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy from/to multidimensional buffers #1985

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

sommerlukas
Copy link
Contributor

Using typed memoryviews restricts queue memcpy to buffers with a single dimension only.

With this change, multi-dimensional buffers with contiguous layout can now be memcpy'd.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @sommerlukas !

The change looks good to me, lets wait for the CI though

@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2025

Coverage Status

coverage: 88.224% (-0.02%) from 88.24%
when pulling a8bc75e on sommerlukas:nd-memory-copy
into d84cb16 on IntelPython:master.

ndgrigorian
ndgrigorian previously approved these changes Feb 5, 2025
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @sommerlukas

@ndgrigorian
Copy link
Collaborator

Noting that the new test passes on both HIP and CUDA devices when the nd-memory-copy branch is built

Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @sommerlukas

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5529d66 into IntelPython:master Feb 7, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants