-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy from/to multidimensional buffers #1985
Copy from/to multidimensional buffers #1985
Conversation
Signed-off-by: Lukas Sommer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix @sommerlukas !
The change looks good to me, lets wait for the CI though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @sommerlukas
Noting that the new test passes on both HIP and CUDA devices when the nd-memory-copy branch is built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @sommerlukas
Using typed memoryviews restricts queue
memcpy
to buffers with a single dimension only.With this change, multi-dimensional buffers with contiguous layout can now be
memcpy
'd.