Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch linting from ufmt+usort+flake8+black to Ruff #1056

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 27, 2023

Summary

This PR switches the lint/format stack from ufmt+usort+flake8+black to Ruff.

I converted the Flake8 configuration with flake8-to-ruff, and adjusted it slightly to make reformatting and import sorting do as little as possible.

🤔 Hmm?

Looks like the codegen'd files have DOS file endings, so I had to unix2dos them after re-generating.

Test Plan

  1. See what CI says.
  2. See what LibCST maintainers say.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f8a9b80) 91.09% compared to head (bf9fc4c) 91.09%.

Files Patch % Lines
libcst/_parser/conversions/params.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         255      255           
  Lines       26564    26564           
=======================================
  Hits        24198    24198           
  Misses       2366     2366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants