Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xpath_compile.py #6767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update xpath_compile.py #6767

wants to merge 1 commit into from

Conversation

Mekaze99
Copy link

@Mekaze99 Mekaze99 commented Oct 11, 2023

Updating file xpath_compile.py to deal with problem with accepting cookies during login

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Do not include any personal data.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project, black -t py34
  • My changes generate no new warnings

Updating file xpath_compile.py to deal with problem with accepting cookies during login
Copy link

@AxelRP AxelRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@abnerrizzi abnerrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ZeyadFarhat11 ZeyadFarhat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchdawson1982
Copy link

Why is this still waiting to be merged?

@Mekaze99
Copy link
Author

Mekaze99 commented May 7, 2024

Idk
I still see "unable to merge" and "review is required"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants