Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting, f-strings #6660

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Formatting, f-strings #6660

wants to merge 4 commits into from

Conversation

marksmayo
Copy link

Description

As per previous attempt, then realised there were flake issues and I'd not used black -t py34. Converted format strings to f-strings and cleaned imports.

Ran pytest. Of note is that pytest fails due to instapy using emoji==1.7, and I had 2.2.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [X ] I have checked my code and corrected any misspellings
  • [ X] I have performed a self-review of my own code
  • [ ]X My code follows the style guidelines of this project, black -t py34
  • [ X] My changes generate no new warnings

marksmayo and others added 4 commits November 26, 2022 18:51
@marksmayo
tidied up imports, cleaned some code
ca4396c 
mainly from pylint warnings
formatting and f-strings
021d7ba 
converted format strings to f-strings
cleaned imports
ran black -t py34 formatting as per project guidelines
Merge branch 'master' of https://github.com/marksmayo/InstaPy
f5dea56
more formatting after merge
046ecab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marksmayo