Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geo ip provider #6629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update geo ip provider #6629

wants to merge 1 commit into from

Conversation

Arwiim
Copy link

@Arwiim Arwiim commented Jul 2, 2022

Pull Request Template

Description

This issue can be found on #6628 but apparently ipbase (freegeoip) no longer provides its json to get ip info

Fixes #6628

How Has This Been Tested?

Create a session and login

  • Test

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project, black -t py34
  • My changes generate no new warnings

This issue can be found on InstaPy#6628 but apparently ipbase (freegeoip) no longer provides its json to get ip info
@jemper12
Copy link

jemper12 commented Jul 6, 2022

It is necessary to replace "query" with "ip" in logger.info

@yuceltoluyag
Copy link

change these lines like this.

logger.info("- Internet Connection Status: ok")

logger.info(
                '- Current IP is "{}" and it\'s from "{}/{}"'.format(
                    current_ip_info["ip"],
                    current_ip_info["country"],
                    current_ip_info["country_code"],
                )

@Reekomer
Copy link

@Arwiim , when I tested it, it just opened Firefox and printed on a page my location. It doesn't go through the login

Copy link

@abnerrizzi abnerrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working view-source:https://freegeoip.app/json
6 participants