Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix internet connection in login (#6612) #6618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix internet connection in login (#6612) #6618

wants to merge 1 commit into from

Conversation

amirsasani
Copy link

Pull Request Template

Description

Fix internet connection issue in login.

Fixes # (#6612)

How Has This Been Tested?

  • Test

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project, black -t py34
  • My changes generate no new warnings

@nihed
Copy link

nihed commented Aug 17, 2022

HI, there is a bug in your commit, you need to change also country_name by country in line 196

abnerrizzi
abnerrizzi approved these changes Dec 24, 2023
View reviewed changes
Copy link

@abnerrizzi abnerrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abnerrizzi
Copy link

HI, there is a bug in your commit, you need to change also country_name by country in line 196

it seems solved any way, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnerrizzi abnerrizzi abnerrizzi approved these changes

@ZeroCoolHacker ZeroCoolHacker ZeroCoolHacker approved these changes

@jaxony1 jaxony1 jaxony1 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amirsasani @nihed @abnerrizzi @ZeroCoolHacker @jaxony1