selection and cursor pos #258
Conversation
|
That's all the features we want to add this time, please let us know when you would be ready with code review. If something needs fixes, let us know too pls. |
| @@ -91,6 +91,7 @@ end | |||
| -- @tfield[opt=*] string MASK_DEFAULT_CHAR Default character mask for password input | |||
| -- @tfield[opt=false] bool IS_UNSELECT_ON_RESELECT If true, call unselect on select selected input | |||
| -- @tfield[opt=false] bool NO_CONSUME_INPUT_WHILE_SELECTED If true, will not consume input while input is selected. It's allow to interact with other components while input is selected (text input still captured) | |||
| -- @tfield[opt=false] bool SKIP_INPUT_KEYS If true, input component will skip processing keys input allowing to process it completely in other components | |||
There was a problem hiding this comment.
I think we should escape the changing input process order from the components
| } | ||
|
|
||
|
|
||
| local function set_cursor(self) | ||
| if self.touch_pos_x then |
There was a problem hiding this comment.
Seems like the touch_pos_x should be as arg of function, wdyt?
| self.input.style.NO_CONSUME_INPUT_WHILE_SELECTED = true | ||
| self.input.style.SKIP_INPUT_KEYS = true | ||
|
|
||
| self.input.cursor_letter_index = 0 |
There was a problem hiding this comment.
Already inited in input component
| local gap = self.input.total_width/2 * -1 | ||
|
|
||
| for i = 1, letters_count do | ||
| cursor_delta = gap + self.text:get_text_size(string.sub(text, 1, i)) - self.half_cursor_width |
There was a problem hiding this comment.
Looks like half_cursor_width can be removed, I rely on this video
Screen.Recording.2024-03-18.at.15.32.56.mov
|
|
||
| self.input.button.on_click:subscribe(on_button_click, self) | ||
| self.input.button.on_double_click:subscribe(on_button_double_click, self) | ||
| self.input.style.NO_CONSUME_INPUT_WHILE_SELECTED = true |
There was a problem hiding this comment.
I think the rich input should not change these style settings (and for skip input keys same)
| gui.set_position(self.cursor, vmath.vector3(self.input.total_width/2, 0, 0)) | ||
| self.input.cursor_letter_index = 1 | ||
| else | ||
| gui.set_position(self.cursor, vmath.vector3(0, 0, 0)) |
There was a problem hiding this comment.
You can create a local TEMP_VECTOR = vector3(0) in module scope, change their fields instead creating vector each time. It allows to save a bit of memory
| @@ -92,4 +172,55 @@ function RichInput.set_placeholder(self, placeholder_text) | |||
| end | |||
|
|
|||
|
|
|||
| function RichInput.on_input(self, action_id, action) | |||
| self.action_pos_x = action.screen_x | |||
There was a problem hiding this comment.
The values action_pos_x and touch_pos_x should not be stored in rich input component. You can use it as a local variables inside only on_input functions
| end | ||
|
|
||
| if action_id == const.ACTION_TEXT then | ||
| --self.input.cursor_letter_index = self.input.cursor_letter_index +1 |
| @@ -219,10 +228,12 @@ function Input.on_input(self, action_id, action) | |||
|
|
|||
| if input_text or #self.marked_value > 0 then | |||
| self:set_text(input_text) | |||
| return true | |||
| --return true | |||
Need some help in rich_input.lua - line 186