Stats logger #10
Draft
Stats logger #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixup1
reviewed
Jan 28, 2025
pixup1
reviewed
Jan 28, 2025
backend/src/statsLogger.ts
Outdated
| @@ -0,0 +1,282 @@ | |||
| import { SqlAttribute, TableSchema } from './tableSchema'; | |||
| import { createTableDB, queryDB, updateDB } from './storage'; | |||
| import { update } from './match'; | |||
pixup1
reviewed
Jan 29, 2025
pixup1
reviewed
Jan 29, 2025
|
I also think it would be interesting to store a timestamp for each match (maybe even two, one for the beginning and one for the end ?) |
Not really necessary, i think, but it could be a future improvement |
|
If we don't record when the matches happened, why does it even make sense to record anything about matches. The data won't make any sense if you can't sort them in the order that they happened during the lan |
pixup1
reviewed
Jan 29, 2025
pixup1
reviewed
Feb 4, 2025
| @@ -17,34 +18,60 @@ export const setup = async () => { | |||
| { name: 'tDiff', type: 'INTEGER' }, | |||
pixup1
reviewed
Feb 4, 2025
| if (!playerExists) { | ||
| await Storage.insertDB( | ||
| StatsLogger.PLAYERS_TABLE, | ||
| new Map<string, string | number>([ |
There was a problem hiding this comment.
diff, hspct and adr should be removed here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stats logging