Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Update OFAC JSON #367

Merged
merged 1 commit into from
Dec 13, 2024
Merged

(fix) Update OFAC JSON #367

merged 1 commit into from
Dec 13, 2024

Conversation

PavelInjective
Copy link
Contributor

@PavelInjective PavelInjective commented Dec 13, 2024

One of the addresses was included with a typo.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected an identifier in the OFAC JSON file.

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Walkthrough

The pull request involves a modification to a JSON file, specifically pyinjective/ofac.json. One hexadecimal string entry has been updated by changing the last character from e to f, resulting in a new identifier. This change affects only one entry in the list, indicating a correction or update to that specific identifier.

Changes

File Change Summary
pyinjective/ofac.json Modified entry from 0x8aa07899eb940f40e514b8efdb3b6af5d1cf7bb to 0x8aa07899eb940f40e514b8effdb3b6af5d1cf7bb.

Possibly related PRs

  • (fix) Update OFAC list URL and filename #362: This PR updates the OFAC_LIST_URL in pyinjective/ofac.py, which is directly related to the changes made in the pyinjective/ofac.json file where the identifier was modified. Both PRs involve updates to the OFAC list and its handling.
  • Feat/sync dev with v1.8.1 #363: This PR includes modifications to the pyinjective/ofac.json file, adding new entries that include the identifier modified in the main PR. The changes in both PRs are connected through the updates to the OFAC list.

🐇 In the JSON file, a change was made,
A hex string's end, a new char displayed.
From e to f, it now does gleam,
A tiny correction, like a dream!
With each little tweak, we hop with cheer,
For every update brings us near! ✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e411e4 and eb70492.

📒 Files selected for processing (1)
  • pyinjective/ofac.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pyinjective/ofac.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@aarmoa aarmoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me

@PavelInjective PavelInjective merged commit 10c7a90 into master Dec 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants