Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/upgrade_protobuf_version #365

Merged
merged 4 commits into from
Dec 13, 2024
+1,331 −1,167
Merged

feat/upgrade_protobuf_version #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e566d5
(fix) Change dependency version to make it more flexible
aarmoa Dec 12, 2024
794a192
(fix) Fixed typo in pyproject.toml
aarmoa Dec 12, 2024
c96b6d5
(fix) Added restriction for importlib-metadata library version to sol…
aarmoa Dec 12, 2024
bdf4a11
(fix) Added Python version specification when installing Python for p…
aarmoa Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ jobs:
uses: actions/checkout@v4
- name: Install Python
uses: actions/setup-python@v5

with:
python-version: '>=3.9 <3.12'
Comment on lines +15 to +16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incorrect Python version constraint syntax for GitHub Actions

The version constraint syntax '>=3.9 <3.12' is not compatible with GitHub Actions' setup-python action. The action expects either a specific version number or a simpler version specification.

Apply this change to fix the syntax:

  with:
-    python-version: '>=3.9 <3.12'
+    python-version: '3.9'

Alternatively, if you need to test against multiple Python versions, consider using a matrix strategy:

jobs:
  pre-commit:
    runs-on: ubuntu-latest
+   strategy:
+     matrix:
+       python-version: ['3.9', '3.10', '3.11']
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-python@v5
        with:
-         python-version: '>=3.9 <3.12'
+         python-version: ${{ matrix.python-version }}

Committable suggestion skipped: line range outside the PR's diff.

- name: Install poetry
run: python -m pip install poetry
- name: Cache the virtualenv
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

All notable changes to this project will be documented in this file.

## [1.8.2] - 2024-12-13
### Changed
- Updated `protobuf` dependency version to make it more flexible

## [1.8.1] - 2024-12-04
### Changed
Expand Down
2 changes: 1 addition & 1 deletion buf.gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ managed:
plugins:
- remote: buf.build/protocolbuffers/python:v26.1
out: ./pyinjective/proto/
- remote: buf.build/grpc/python:v1.65.4
- remote: buf.build/grpc/python:v1.65.5
out: ./pyinjective/proto/
inputs:
- module: buf.build/cosmos/cosmos-proto
Expand Down
Loading
Loading