-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/sync dev with v1 55 0 #273
Conversation
…allow using the Sync broadcast without passing though the SDK mechanism to ensure the TX is included in one of the next blocks (CHAIN-277)
feat/tx_broadcast_refactoring
… feat/sync_dev_with_v1_55_0
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="[lintersdb] The name "gas" is deprecated. The linter has been renamed to: gosec." WalkthroughThis pull request introduces a new Changes
Sequence DiagramsequenceDiagram
participant Client
participant ChainClient
participant Blockchain
Client->>ChainClient: BroadcastMsg(mode, messages)
ChainClient->>Blockchain: Submit Transaction
alt Synchronous Mode
Blockchain-->>ChainClient: Wait for Block Inclusion
ChainClient-->>Client: Return Transaction Response
else Asynchronous Mode
Blockchain-->>ChainClient: Immediate Response
ChainClient-->>Client: Return Immediate Response
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (13)
Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
dev
branch with the changes in the release v1.55.0Summary by CodeRabbit
New Features
Improvements
Documentation
Chores